Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: migrate part of form tests #37727

Merged
merged 17 commits into from
Sep 26, 2022
Merged

test: migrate part of form tests #37727

merged 17 commits into from
Sep 26, 2022

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Sep 25, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

test: migrate part of form tests

Language Changelog
🇺🇸 English test: migrate part of form tests
🇨🇳 Chinese test 迁移

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Sep 25, 2022

@codecov
Copy link

codecov bot commented Sep 25, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4bf6176) compared to base (a70ef1b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #37727   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          443       443           
  Lines         8204      8204           
  Branches      2421      2421           
=========================================
  Hits          8204      8204           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan mentioned this pull request Sep 25, 2022
15 tasks
@afc163 afc163 merged commit 1885860 into ant-design:master Sep 26, 2022
@li-jia-nan li-jia-nan deleted the form branch September 26, 2022 01:56
@zombieJ zombieJ mentioned this pull request Sep 26, 2022
@MadCcc MadCcc mentioned this pull request Sep 29, 2022
19 tasks
await Promise.resolve();
formRef.current?.setFieldsValue({ light: 'bamboo' });

await waitFakeTimer();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里是不是导致 test 失败了?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里有什么问题嘛?我本地是跑过了的

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#37930

这里 test 失败了,shouldRender 应该 call 两次,测试只 call 了一次

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants