Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): add titles for transfer in locale #38168

Merged
merged 1 commit into from Oct 23, 2022

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Oct 22, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

add titles for transfer in locale

📝 Changelog

Language Changelog
🇺🇸 English add titles for transfer in locale
🇨🇳 Chinese 在本地化文件中为transfer组件添加titles属性

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Oct 22, 2022

@codecov
Copy link

codecov bot commented Oct 22, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e0bfbfb) compared to base (ba3ab89).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38168   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          444       444           
  Lines         8219      8219           
  Branches      2496      2496           
=========================================
  Hits          8219      8219           
Impacted Files Coverage Δ
components/locale/ar_EG.tsx 100.00% <ø> (ø)
components/locale/bg_BG.tsx 100.00% <ø> (ø)
components/locale/da_DK.tsx 100.00% <ø> (ø)
components/locale/el_GR.tsx 100.00% <ø> (ø)
components/locale/fi_FI.tsx 100.00% <ø> (ø)
components/locale/fr_BE.tsx 100.00% <ø> (ø)
components/locale/fr_CA.tsx 100.00% <ø> (ø)
components/locale/gl_ES.tsx 100.00% <ø> (ø)
components/locale/he_IL.tsx 100.00% <ø> (ø)
components/locale/hu_HU.tsx 100.00% <ø> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Oct 23, 2022

Transfer 本身也需要判断一下,避免报错。

@afc163 afc163 merged commit 80ad128 into ant-design:master Oct 23, 2022
@kiner-tang
Copy link
Member Author

Transfer 本身也需要判断一下,避免报错。

好的,在这里增加了一下代码优化:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transfer 中文语言包缺少titles配置导致运行错误,错误位置transfer/index.tsx:388行,424行
2 participants