New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(table): no border-bottom when the cells are merged #38735
fix(table): no border-bottom when the cells are merged #38735
Conversation
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #38735 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 544 544
Lines 9368 9353 -15
Branches 2650 2649 -1
=========================================
- Hits 9368 9353 -15
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
可以补充一个测试用例吗? |
Hi @li-jia-nan! Thanks for the reminder! But I don't know how to add unit tests for the CSS changes. Could you give me some more advice? <3 |
const element = container.querySelector<HTMLDivElement>('xxxx');
const getStyle = getComputedStyle(element);
expect(getStyle.borderBlockEnd).toBe('xxxx'); |
这样的测试用例没啥意义,不能保证样式是对的。 |
OK,那这个让闲夕大佬来跟进一下,我就不管啦❤️❤️❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样会让 table 丢失底部 border,看 https://preview-38735-ant-design.surge.sh/components/table-cn#components-table-demo-basic
最好和 4.x 样式对对,看看哪个样式缺了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这样会让 table 丢失底部 border,看 https://preview-38735-ant-design.surge.sh/components/table-cn#components-table-demo-basic
最好和 4.x 样式对对,看看哪个样式缺了
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Closes: #38724
💡 Background and solution
Add
border-block-end
to.ant-table-container
to implement the bottom border of the table.📝 Changelog
☑️ Self-Check before Merge