Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(badge): add debug demo #38828

Closed
wants to merge 2 commits into from

Conversation

Wxh16144
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

在解决 #38806 问题时,参考 v4 的自定义 offset Demo,在设置 direction=rtl 时,实际渲染的样式问题。

我们是否应该将这里的 left 也设置为负数? 没有看到有关的测试用例,所以我添加了一个调试 demo

offsetStyle.left = parseInt(offset[0] as string, 10);

📝 Changelog

Language Changelog
🇺🇸 English
🇨🇳 Chinese

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2022

@codecov
Copy link

codecov bot commented Nov 21, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (7d63e37) compared to base (4288039).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           4.x-stable    #38828   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             447       447           
  Lines            8323      8323           
  Branches         2534      2534           
============================================
  Hits             8323      8323           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wxh16144
Copy link
Member Author

Maintain status quo

@Wxh16144 Wxh16144 closed this Nov 22, 2022
Wxh16144 added a commit to Wxh16144-forks/ant-design that referenced this pull request Nov 22, 2022
afc163 pushed a commit that referenced this pull request Nov 22, 2022
* chore: update style

* docs(badge): add debug demo

* test: update snapshot

* test: offset solution

ref: #38828

* chore: update style

* Revert "test: offset solution"

This reverts commit aacf9c3.

* Revert "docs(badge): add debug demo"

This reverts commit 52b0dab.

* test: update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant