Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(site): improve site #39504

Merged
merged 9 commits into from
Dec 19, 2022
Merged

chore(site): improve site #39504

merged 9 commits into from
Dec 19, 2022

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Dec 12, 2022 •
edited

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 合并 Adapt to the mobile mode of the new official website #39043 新建的 SiteContext
  • 将主题(theme) 添加到 SiteContext 中
    • 和主题相关的可以不用通过 url 获取，统一使用 context 获取
  • 在 SiteContext 提供修改方法 updateSiteCinfig 功能方法
    • 提供给设置 direction， theme 时使用
  • 移除右下角默认主题切换按钮 (与 site: icon update #39534 重复了, 已解决冲突
  • 修复 组件总览点击进入组件详情时，url 参数丢失问题
  • 修复 组件 Demo 展开代码图标根据主题切换逻辑问题
  • 修复暗色主题下，组件汇总页搜索输入框颜色错误问题
  • 修复暗色主题下，顶部语言切换字体颜色错误问题

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 12, 2022 •
edited

Wxh16144
Wxh16144 commented Dec 12, 2022
View reviewed changes
.dumi/theme/builtins/Previewer/fromDumiProps.tsx
@@ -89,7 +88,6 @@ export default function fromDumiProps<P extends object>(
expand,
// FIXME: confirm is there has any case?
highlightedStyle: '',
theme: searchParams.get('theme'),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2022-12-13.01-29-20.mp4

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

问题是啥？

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

因为 url 里面的 theme 会有多个， 比如 url=xxx?theme=compact&theme=dark 通过 theme: searchParams.get('theme') 只会获取第一个

@codecov
Copy link

codecov bot commented Dec 12, 2022 •
edited

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (e8a832c) compared to base (b04b759).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master    #39504   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9363      9362    -1     
  Branches      2653      2652    -1     
=========================================
- Hits          9363      9362    -1
Impacted Files Coverage Δ
components/dropdown/dropdown-button.tsx 100.00% <ø> (ø)
components/modal/PurePanel.tsx 100.00% <ø> (ø)
components/popconfirm/PurePanel.tsx 100.00% <ø> (ø)
components/transfer/operation.tsx 100.00% <ø> (ø)
components/_util/ActionButton.tsx 100.00% <100.00%> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)
components/modal/Modal.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Wxh16144
Copy link
Member Author

Wxh16144 commented Dec 12, 2022 •
edited

上面两个地址 theme 都会被吞 ?theme=dark&theme=compact

ant.design 又不会出现这个场景

@MadCcc
Copy link
Member

MadCcc commented Dec 13, 2022

PR 里写下改动点？

@Wxh16144
Copy link
Member Author

PR 里写下改动点？

已经补充~

@Wxh16144 Wxh16144 requested a review from afc163 December 14, 2022 19:28
@Wxh16144
Copy link
Member Author

基本上就这些改动吧，后面再有调整，我重新开 PR。 改动太多了 Review 有点辛苦

@Wxh16144
Merge branch 'master' into wuxh/site
e8a832c 
* master:
  fix: Table should not warn DefaultProps (ant-design#39571)
  type: Button type optimization (ant-design#39533)
  docs: Add Form prefix demo (ant-design#39580)
  site: icon update (ant-design#39534)
  demo: update demo (ant-design#39576)
  fix: segmented icon margin (ant-design#39575)
  type: add FloatButtonGroupProps (ant-design#39553)
  fix: add img cdn link for site (ant-design#39554)
  docs: Tree conduction (ant-design#39566)
@MadCcc MadCcc enabled auto-merge (squash) December 19, 2022 03:42
@MadCcc MadCcc merged commit 36abb3d into ant-design:master Dec 19, 2022
@afc163
Copy link
Member

afc163 commented Dec 22, 2022

@Wxh16144 这个引起了 #39687 (comment) 的问题。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MadCcc MadCcc MadCcc approved these changes

@afc163 afc163 Awaiting requested review from afc163

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Wxh16144 @MadCcc @afc163