Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove lodash/debounce #39602

Merged
merged 3 commits into from Dec 16, 2022
Merged

chore: remove lodash/debounce #39602

merged 3 commits into from Dec 16, 2022

Conversation

li-jia-nan
Copy link
Member

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English chore: remove lodash/debounce
🇨🇳 Chinese chore: remove lodash/debounce

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2022

size-limit report 📦

Path Size
./dist/antd.min.js 374.16 KB (+175 B 🔺)
./dist/antd-with-locales.min.js 427.6 KB (+166 B 🔺)

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 16, 2022

should cancel debounce function when unmount 这个用例失败了.

@yoyo837
Copy link
Contributor

yoyo837 commented Dec 16, 2022

把它用例的 lodash/debounce 也换掉吧?

@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (d60a9a4) compared to base (b82c4bf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #39602   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          546       546           
  Lines         9362      9363    +1     
  Branches      2652      2653    +1     
=========================================
+ Hits          9362      9363    +1     
Impacted Files Coverage Δ
components/spin/index.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan
Copy link
Member Author

把它用例的 lodash/debounce 也换掉吧?

done

@li-jia-nan li-jia-nan merged commit 1f5ab2d into master Dec 16, 2022
@li-jia-nan li-jia-nan deleted the debounce branch December 16, 2022 07:02
@MadCcc
Copy link
Member

MadCcc commented Dec 16, 2022

怎么包体积还变大了

@li-jia-nan
Copy link
Member Author

rc-align 和 react-slick 里面的 lodash 还没干掉

@MadCcc MadCcc mentioned this pull request Dec 18, 2022
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants