Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create modal #39660

Closed
wants to merge 17 commits into from
Closed

Create modal #39660

wants to merge 17 commits into from

Conversation

bowencool
Copy link

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Use create() to create a one-time modal dialog dynamically without maintenance loading and visible. Let onCancel/onOk function return a promise object to delay closing the dialog. onOK takes the parameters passed by the content component.
🇨🇳 Chinese 使用 create() 可以快捷地创建一次性弹窗,无需维护 loading 和 visible。 onCancel/onOk 返回 promise 可以延迟关闭。 onOk 可以拿到内容组件传递的参数。

☑️ Self-Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022

@bowencool
Copy link
Author

bowencool commented Dec 19, 2022

之前提过一次:#36734 ,这次添加了结合 useModal 的用法。可以看下这个设计如何,如果可以的话我再继续完善代码、文档、PR等。

@bowencool bowencool marked this pull request as ready for review December 19, 2022 12:46
@bowencool bowencool marked this pull request as draft December 19, 2022 12:48
@bowencool bowencool changed the base branch from master to feature December 19, 2022 13:06
@afc163
Copy link
Member

afc163 commented Dec 24, 2022

我们目前没有计划继续增强 static 方法的使用,还是推荐用 useModal 或 。

@afc163 afc163 closed this Dec 24, 2022
@bowencool
Copy link
Author

已经抽象到单独的包,详情查看:https://bowencool.github.io/create-antd-modal/documents/functions/create-modal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants