Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed two compiling errors reported by typescript 2.0.10. #3969

Merged

Conversation

AlbertZheng
Copy link
Contributor

@AlbertZheng AlbertZheng commented Nov 23, 2016

First of all, thanks for your contribution! :-)

Please makes sure these boxes are checked before submitting your PR, thank you!

  • Make sure you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

What are fixed?

Below two compiling errors reported by tsc 2.0.10 are fixed:

ERROR in ...../node_modules/antd/lib/tag/CheckableTag.d.ts
(7,17): error TS7006: Parameter 'checked' implicitly has an 'any' type.

ERROR in ....../node_modules/antd/lib/table/createStore.d.ts
(2,16): error TS7006: Parameter 'Object' implicitly has an 'any' type.

@mention-bot
Copy link

@AlbertZheng, thanks for your PR! By analyzing the history of the files in this pull request, we identified @yesmeck and @benjycui to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 74.876% when pulling adde579 on AlbertZheng:fixes-for-tsc2.0.10-compiling-errors into 7b61b84 on ant-design:master.

@benjycui
Copy link
Contributor

snapshot 的问题 @yesmeck 看下?

@yesmeck
Copy link
Member

yesmeck commented Nov 23, 2016

master 上测试修复了。

@benjycui
Copy link
Contributor

我奇怪的是,这个 compile 错误为什么之前 CI 没有查出来。。

@benjycui benjycui merged commit 5e1b679 into ant-design:master Nov 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants