Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: should not throw error when percent is null #40378

Merged
merged 5 commits into from Jan 29, 2023
Merged

fix: should not throw error when percent is null #40378

merged 5 commits into from Jan 29, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jan 23, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: should not throw error when percent is null
🇨🇳 Chinese fix: should not throw error when percent is null

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jan 23, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 367.32 KB (+17 B 🔺)
./dist/antd-with-locales.min.js 423.09 KB (+18 B 🔺)

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (c2a4450) compared to base (1898c5b).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #40378   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          605       605           
  Lines        10306     10306           
  Branches      2774      2774           
=========================================
  Hits         10306     10306           
Impacted Files Coverage Δ
components/progress/progress.tsx 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@li-jia-nan li-jia-nan merged commit 08a457c into master Jan 29, 2023
@li-jia-nan li-jia-nan deleted the progress branch January 29, 2023 03:50
@PeachScript PeachScript mentioned this pull request Jan 31, 2023
20 tasks
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
* fix: should not throw error when percent in null

* fix

* fix

* fix
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: should not throw error when percent in null

* fix

* fix

* fix
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
* fix: should not throw error when percent in null

* fix

* fix

* fix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress throw when providing undefined percent
2 participants