-
-
Notifications
You must be signed in to change notification settings - Fork 46.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FloatButtonGroup): Add onClick prop #40706
base: feature
Are you sure you want to change the base?
feat(FloatButtonGroup): Add onClick prop #40706
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature #40706 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 739 708 -31
Lines 12688 12101 -587
Branches 3334 3207 -127
==========================================
- Hits 12688 12101 -587 ☔ View full report in Codecov by Sentry. |
Any senario in real world needs this prop? Is |
@MadCcc |
In this case |
You're correct, but |
@MadCcc |
We worry it is easy to cause ambiguity, some people will think that the click of the FloatButtonGroup is the entire area, and some people will think it is the trigger button. |
Thank you for bringing up the concern about ambiguity. I agree that choosing a clear and meaningful name for the click area would be the best solution to avoid any confusion. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job!
Conflicting |
Signed-off-by: Riyad Elberkawy <riyad.elberkawy@gmail.com>
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 87135be:
|
@afc163 |
👁 Visual Regression Report for PR #40706 Passed ✅
🎊 Congrats! No visual-regression diff found. |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge