Repository navigation
style: Checkbox should use @border-radius-sm - #40823
Merged
Merged
Conversation
Contributor
li-jia-nan
approved these changes
Feb 20, 2023
Member
Author
|
/rebase |
github-actions
Bot
force-pushed
the
style/checkbox-radius
branch
from
February 21, 2023 08:53
efbd533 to
d65b678
Compare
afc163
force-pushed
the
style/checkbox-radius
branch
from
February 21, 2023 08:56
d65b678 to
02152ed
Compare
Contributor
size-limit report 📦
|
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## 4.x-stable #40823 +/- ##
============================================
Coverage 100.00% 100.00%
============================================
Files 450 450
Lines 8333 8333
Branches 2539 2539
============================================
Hits 8333 8333 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
不太理解此改动,为什么只修改default.less,而variable.less还是@checkbox-border-radius: @border-radius-base; |
Member
Author
|
@BanShan-Alec 改漏了,欢迎 PR |
4 of 20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
参考 V5 的改动:93908de#diff-17c6a64972b945a29c5a53348d97412a776a8f23badd84a04280998c0f4c0462
Checkbox 应该使用小号圆角,避免修改默认圆角导致 Checkbox 接近圆形,太像 Radio。
📝 Changelog
@border-radius-sm小号圆角。☑️ Self-Check before Merge