Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Checkbox should use @border-radius-sm #40823

Merged
merged 1 commit into from Feb 21, 2023
Merged

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Feb 20, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

参考 V5 的改动:93908de#diff-17c6a64972b945a29c5a53348d97412a776a8f23badd84a04280998c0f4c0462

Checkbox 应该使用小号圆角,避免修改默认圆角导致 Checkbox 接近圆形,太像 Radio。

图片

📝 Changelog

Language Changelog
🇺🇸 English Checkbox should use @border-radius-sm
🇨🇳 Chinese Checkbox 默认使用 @border-radius-sm 小号圆角。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 20, 2023

@afc163
Copy link
Member Author

afc163 commented Feb 21, 2023

/rebase

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 281.19 KB
./dist/antd.min.css 66.27 KB
./dist/antd.dark.min.css 67.51 KB
./dist/antd.compact.min.css 66.22 KB
./dist/antd.variable.min.css 66.81 KB

@codecov
Copy link

codecov bot commented Feb 21, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (02152ed) compared to base (517cd60).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           4.x-stable    #40823   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             450       450           
  Lines            8333      8333           
  Branches         2539      2539           
============================================
  Hits             8333      8333           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit a42a488 into 4.x-stable Feb 21, 2023
@afc163 afc163 deleted the style/checkbox-radius branch February 21, 2023 10:02
@zombieJ zombieJ mentioned this pull request Apr 19, 2023
16 tasks
@BanShan-Alec
Copy link

不太理解此改动,为什么只修改default.less,而variable.less还是@checkbox-border-radius: @border-radius-base;

@afc163
Copy link
Member Author

afc163 commented Jun 28, 2023

@BanShan-Alec 改漏了,欢迎 PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants