Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Cascader warning when use displayRender and multiple together #40940

Merged
merged 1 commit into from Feb 28, 2023

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Feb 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English The displayRender prompt cannot be used when deleting multiple
🇨🇳 Chinese 删除 multiple 不能使用 displayRender 提示

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

🚨 Hi @crazyair. Thanks for your contribution, as the default.less file is currently being upgraded, changes are not recommended.

🚨 你好,@crazyair。感谢你的贡献,由于 default.less 文件近期处于升级状态,不建议进行更改。

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

@crazyair crazyair changed the base branch from master to 4.x-stable February 27, 2023 08:12
@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (0dd57fc) compared to base (b4015b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##           4.x-stable    #40940   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             450       450           
  Lines            8333      8331    -2     
  Branches         2539      2538    -1     
============================================
- Hits             8333      8331    -2     
Impacted Files Coverage Δ
components/cascader/index.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ
Copy link
Member

zombieJ commented Feb 27, 2023

测试用例里也清一下?

@crazyair
Copy link
Member Author

测试用例里也清一下?

看了下,没写单测

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 281.18 KB
./dist/antd.min.css 66.27 KB
./dist/antd.dark.min.css 67.51 KB
./dist/antd.compact.min.css 66.22 KB
./dist/antd.variable.min.css 66.81 KB

@afc163 afc163 changed the title fix: 删除多选模不能使用 displayRender 提示 fix: remove Cascader warning when use displayRender and multiple together Feb 27, 2023
@afc163 afc163 merged commit 7a3c492 into 4.x-stable Feb 28, 2023
@afc163 afc163 deleted the fix-cascader-warn branch February 28, 2023 02:07
@zombieJ zombieJ mentioned this pull request Apr 19, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants