Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove Cascader warning when use displayRender and multiple together #40941

Merged
merged 2 commits into from Feb 27, 2023

Conversation

crazyair
Copy link
Member

@crazyair crazyair commented Feb 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English The displayRender prompt cannot be used when deleting multiple
🇨🇳 Chinese 删除 multiple 不能使用 displayRender 提示

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Feb 27, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 368.24 KB
./dist/antd-with-locales.min.js 424.55 KB

@zombieJ
Copy link
Member

zombieJ commented Feb 27, 2023

测试用例里也清一下?

@crazyair
Copy link
Member Author

测试用例里也清一下?

看了下,没写单测

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (4ff3e4f) compared to base (ab83c1b).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #40941   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          606       606           
  Lines        10285     10283    -2     
  Branches      2790      2789    -1     
=========================================
- Hits         10285     10283    -2     
Impacted Files Coverage Δ
components/cascader/index.tsx 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Feb 27, 2023

为啥要删?背景是啥

@crazyair
Copy link
Member Author

crazyair commented Feb 27, 2023

为啥要删?背景是啥

#34116 这个修改时候忘了删掉 warn

@afc163 afc163 changed the title fix: 删除多选模不能使用 displayRender 提示 fix: remove Cascader warning when use displayRender and multiple together Feb 27, 2023
@afc163 afc163 merged commit c4273ec into master Feb 27, 2023
@afc163 afc163 deleted the fix-cascader-warn-master branch February 27, 2023 11:48
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 4, 2023
…ther (ant-design#40941)

* fix: 删除多选模不能使用 displayRender 提示

* fix: 删除多选模不能使用 displayRender 提示
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
…ther (ant-design#40941)

* fix: 删除多选模不能使用 displayRender 提示

* fix: 删除多选模不能使用 displayRender 提示
RedJue pushed a commit to RedJue/ant-design that referenced this pull request Apr 25, 2023
…ther (ant-design#40941)

* fix: 删除多选模不能使用 displayRender 提示

* fix: 删除多选模不能使用 displayRender 提示
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants