Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: radio button在disabled和checked状态多了点box-shadow #4114

Merged
merged 1 commit into from
Dec 5, 2016
Merged

fix: radio button在disabled和checked状态多了点box-shadow #4114

merged 1 commit into from
Dec 5, 2016

Conversation

jdz321
Copy link
Contributor

@jdz321 jdz321 commented Dec 2, 2016

sc

@mention-bot
Copy link

@jdz321, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjycui, @afc163 and @jljsj33 to be potential reviewers.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.57% when pulling ba1573d761465873d1b55a77812affc4999307f8 on jdz321:fix-radio-button into 575f0db on ant-design:master.

afc163
afc163 requested changes Dec 2, 2016
View reviewed changes
Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感谢 PR !~ 👍

  1. package.json 和 radiobutton.md 不用改动。
  2. 邮箱信息建议修改或绑定一下。

@afc163
Copy link
Member

afc163 commented Dec 3, 2016

@jdz321

@jdz321
Copy link
Contributor Author

jdz321 commented Dec 5, 2016

done 2333

@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 76.589% when pulling 3de1799fef9aa887edd521c630e7e441cad0f210 on jdz321:fix-radio-button into 575f0db on ant-design:master.

@afc163
Copy link
Member

afc163 commented Dec 5, 2016

image

@jdz321 jdz321 closed this Dec 5, 2016
@jdz321 jdz321 reopened this Dec 5, 2016
@jdz321
Copy link
Contributor Author

jdz321 commented Dec 5, 2016

我把那条ci删了 好麻烦 orz

@coveralls
Copy link

Coverage Status

Coverage remained the same at 76.589% when pulling 53b0154 on jdz321:fix-radio-button into 392805e on ant-design:master.

@afc163 afc163 merged commit 57bb12c into ant-design:master Dec 5, 2016
@jdz321 jdz321 deleted the fix-radio-button branch December 5, 2016 05:49
@ystarlongzi
Copy link
Contributor

<ButtonGroup /> 里如果将 primary 和另外两种状态混用，也有同样的问题，查看demo。

另外，感觉 button/style/index.less 的 .@{btn-prefix-cls} 是不是可以改成 &

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afc163 afc163 afc163 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jdz321 @mention-bot @coveralls @afc163 @ystarlongzi