fix: Adds aria-* to TreeSelect #41978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #41978 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 616 616
Lines 10529 10531 +2
Branches 2882 2884 +2
=========================================
+ Hits 10529 10531 +2
... and 2 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Could we support aria-*？ |
I have done this ~~~ |
guan404ming
changed the title
afc163
reviewed
Apr 25, 2023
afc163
approved these changes
Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 8b2bbea
This pull request enhances the accessibility of the
TreeSelectcomponent by adding thearia-labelprop, which allows users to specify custom labels for the tree nodes. It also adds a test case to verify the functionality of the new prop.🔍 Walkthrough
🤖 Generated by Copilot at 8b2bbea
aria-labelprop toTreeSelectcomponent to support accessibility labels (link, link, link, link)aria-labelprop inTreeSelectPropsinterface incomponents/tree-select/index.tsx(link)aria-labelprop toariaLabelvariable inInternalTreeSelectfunction incomponents/tree-select/index.tsx(link)ariaLabelvariable torc-tree-selectcomponent inInternalTreeSelectfunction incomponents/tree-select/index.tsx(link)aria-labelprop incomponents/tree-select/__tests__/index.test.tsx(link)