Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate less to token for Message #42080

Merged
merged 1 commit into from May 4, 2023
Merged

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Apr 29, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English migrate less to token for Message
🇨🇳 Chinese 迁移 Message 组件的 less token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at eba4ebe

Refactored the style tokens for the Message component and updated the documentation for migrating less variables to component tokens. This makes the Message component more consistent and easier to customize.

🔍 Walkthrough

🤖 Generated by Copilot at eba4ebe

  • Move common message tokens to ComponentToken interface (link)
  • Remove redundant messageNoticeContentPadding token from mergeToken function (link)
  • Add messageNoticeContentBg and messageNoticeContentPadding tokens to genMessageStyle function to generate CSS style for message components (link)
  • Update documentation for migrating less variables to component tokens for Message component, listing the mapping and notes for the tokens (link, link)

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Apr 29, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 376.75 KB (+10 B 🔺)
./dist/antd-with-locales.min.js 435.68 KB (+9 B 🔺)

@codecov
Copy link

codecov bot commented Apr 29, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (4a4eae5) 100.00% compared to head (57afc13) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42080   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          619       619           
  Lines        10581     10581           
  Branches      2890      2890           
=========================================
  Hits         10581     10581           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 18b7d1b into feature May 4, 2023
85 checks passed
@MadCcc MadCcc deleted the message-component-token2 branch May 4, 2023 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants