New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: migrate less to token for Skeleton #42134
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
51 tasks
size-limit report 📦
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #42134 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 619 640 +21
Lines 11048 10855 -193
Branches 3081 2950 -131
==========================================
- Hits 11048 10855 -193
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
May 5, 2023
MadCcc
reviewed
May 5, 2023
MadCcc
reviewed
May 5, 2023
kiner-tang
force-pushed
the
skeleton-component-token
branch
from
May 7, 2023 01:11
94bd4d6
to
fcf50d9
Compare
kiner-tang
force-pushed
the
skeleton-component-token
branch
from
May 12, 2023 23:50
11d191a
to
2f37d90
Compare
MadCcc
reviewed
May 17, 2023
MadCcc
reviewed
May 18, 2023
MadCcc
reviewed
May 18, 2023
Co-authored-by: MadCcc <1075746765@qq.com>
MadCcc
reviewed
May 18, 2023
MadCcc
reviewed
May 18, 2023
MadCcc
reviewed
May 18, 2023
MadCcc
approved these changes
May 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
Skeleton
组件的less token
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 379d44f
This pull request refactors the
Skeleton
component style to use theComponentToken
type and updates the documentation for migrating from Less variables to Component Token in both English and Chinese.🔍 Walkthrough
🤖 Generated by Copilot at 379d44f
skeletonTitleHeight
andskeletonBlockRadius
properties toComponentToken
type to customize skeleton blocks (link)SkeletonToken
interface and adjusttoken
object assignment accordingly (link, link, link)Skeleton
component token mapping in English and Chinese versions ofdocs/react/migrate-less-variables.md
(link, link)docs/react/migrate-less-variables.md
for both languages for formatting consistency (link, link, link, link, link, link, link, link)