Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate less to token for Skeleton #42134

Merged
merged 28 commits into from May 18, 2023
Merged

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented May 4, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English migrate less to token for Skeleton
🇨🇳 Chinese 迁移 Skeleton 组件的 less token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 379d44f

This pull request refactors the Skeleton component style to use the ComponentToken type and updates the documentation for migrating from Less variables to Component Token in both English and Chinese.

🔍 Walkthrough

🤖 Generated by Copilot at 379d44f

  • Add skeletonTitleHeight and skeletonBlockRadius properties to ComponentToken type to customize skeleton blocks (link)
  • Remove redundant properties from SkeletonToken interface and adjust token object assignment accordingly (link, link, link)
  • Add documentation for Skeleton component token mapping in English and Chinese versions of docs/react/migrate-less-variables.md (link, link)
  • Remove empty lines from various sections of docs/react/migrate-less-variables.md for both languages for formatting consistency (link, link, link, link, link, link, link, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 4, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 383.89 KB (+558 B 🔺)
./dist/antd-with-locales.min.js 443.16 KB (+516 B 🔺)

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (24dd535) 100.00% compared to head (6d8af8a) 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           feature    #42134    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files          619       640    +21     
  Lines        11048     10855   -193     
  Branches      3081      2950   -131     
==========================================
- Hits         11048     10855   -193     
Impacted Files Coverage Δ
components/auto-complete/index.tsx 100.00% <ø> (ø)
components/config-provider/context.ts 100.00% <ø> (ø)
components/divider/style/index.ts 100.00% <ø> (ø)
components/input-number/style/index.ts 100.00% <ø> (ø)
components/input/style/index.ts 100.00% <ø> (ø)
components/locale/en_US.ts 100.00% <ø> (ø)
components/locale/index.tsx 100.00% <ø> (ø)
components/locale/zh_CN.ts 100.00% <ø> (ø)
components/menu/MenuItem.tsx 100.00% <ø> (ø)
components/menu/hooks/useItems.tsx 100.00% <ø> (ø)
... and 61 more

... and 21 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@kiner-tang kiner-tang requested a review from MadCcc May 5, 2023 01:43
@kiner-tang kiner-tang requested a review from MadCcc May 5, 2023 02:13
@kiner-tang kiner-tang closed this May 5, 2023
@kiner-tang kiner-tang reopened this May 5, 2023
@kiner-tang kiner-tang closed this May 6, 2023
@kiner-tang kiner-tang reopened this May 6, 2023
@kiner-tang kiner-tang requested a review from MadCcc May 13, 2023 04:20
@kiner-tang kiner-tang requested a review from zombieJ May 15, 2023 06:13
@MadCcc
Copy link
Member

MadCcc commented May 17, 2023

image
还有一些间距也可以迁过来

@kiner-tang
Copy link
Member Author

image 还有一些间距也可以迁过来

done

@kiner-tang kiner-tang requested a review from MadCcc May 18, 2023 05:58
@MadCcc MadCcc merged commit 65d7a5b into feature May 18, 2023
83 checks passed
@MadCcc MadCcc deleted the skeleton-component-token branch May 18, 2023 13:18
@MadCcc MadCcc mentioned this pull request Jun 6, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants