Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: migrate less to token for Switch #42192

Merged
merged 7 commits into from Aug 16, 2023
Merged

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented May 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

ref #41884

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Migrate Switch less variables
🇨🇳 Chinese 迁移 Switch less 变量

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 26c5f31

Refactor the switch component to use component tokens and update the documentation for migrating less variables. The code improves the switch component's styling and performance, and adds a new section for the Switch component in both the English and Chinese documentation files. The code also removes some unnecessary empty lines and improves the formatting and consistency of the documentation files.

🔍 Walkthrough

🤖 Generated by Copilot at 26c5f31

  • Refactor switch component to use component tokens instead of less variables for styling (link, link, link, link, link)
  • Document the mapping between less variables and component tokens for the switch component and provide some notes on the changes in both English and Chinese versions of the documentation for migrating less variables (link, link)
  • Remove empty lines from various sections of the documentation for migrating less variables to improve the formatting and consistency (link, link, link, link, link, link, link, link, link, link, link, link)

@github-actions
Copy link
Contributor

github-actions bot commented May 6, 2023

Prepare preview

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (65989b4) 100.00% compared to head (d2e3c9c) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42192   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          663       663           
  Lines        11267     11270    +3     
  Branches      3047      3047           
=========================================
+ Hits         11267     11270    +3     
Files Changed Coverage Δ
components/switch/style/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yoyo837 yoyo837 mentioned this pull request May 6, 2023
51 tasks
@github-actions
Copy link
Contributor

Hi @Yuiai01. Thanks for your contribution. The path .github/ or scripts/ and CHANGELOG is only maintained by team members. This current PR will be closed and team members will help on this.

@argos-ci
Copy link

argos-ci bot commented Aug 16, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 11 changes Aug 16, 2023, 10:09 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants