feat(ColorPicker): add destroyTooltipOnHide #42645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
看下是否需要改成名字，现在是直接拿的 popover 的属性名 destroyTooltipOnHide |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## feature #42645 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 650 650
Lines 10956 10956
Branches 2971 2971
=========================================
Hits 10956 10956
☔ View full report in Codecov by Sentry. |
|
不确定需不需要，内部讨论下。 |
MadCcc
reviewed
May 26, 2023
MadCcc
reviewed
May 26, 2023
…color-picker-destory-hide
MadCcc
approved these changes
Jun 19, 2023
li-jia-nan
reviewed
Jun 19, 2023
| @@ -48,6 +48,7 @@ group: | |||
| | disabled | 禁用颜色选择器 | boolean | - | | |||
| | placement | 弹出窗口的位置 | `top` \| `topLeft` \| `topRight` \| `bottom` \| `bottomLeft` \| `bottomRight` | `bottomLeft` | | |||
| | arrow | 配置弹出的箭头 | `boolean \| { pointAtCenter: boolean }` | `true` | - | | |||
| | destroyTooltipOnHide | 关闭后是否销毁弹窗 | `boolean` | `false` | | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
页面中 ColorPicker 比较多时，打开后 dom 数量比较多
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 82bace3
Add a new prop
destroyTooltipOnHideto theColorPickercomponent, which controls whether the color state is preserved or reset when the popover is hidden. Update the English and Chinese documentation for the component accordingly.🔍 Walkthrough
🤖 Generated by Copilot at 82bace3
destroyTooltipOnHideprop toColorPickercomponent to control whether the popover should be destroyed when hidden or not (link, link, link, link, link)ColorPickerPropsinterface withdestroyTooltipOnHideprop inherited fromPopoverPropsinterface incomponents/color-picker/ColorPicker.tsx(link)destroyTooltipOnHideprop touseColorPickerhook and use it to reset color state when popover is hidden incomponents/color-picker/ColorPicker.tsx(link)destroyTooltipOnHideprop toPopovercomponent and forward it torc-triggercomponent incomponents/color-picker/ColorPicker.tsx(link)destroyTooltipOnHideprop and its default value in English and Chinese documentation files incomponents/color-picker/index.en-US.mdandcomponents/color-picker/index.zh-CN.md(link, link)