Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(badge): migrate less to token #42778

Merged
merged 15 commits into from Aug 14, 2023

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Jun 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English migrate less to token for <Badge />
🇨🇳 Chinese 迁移 <Badge /> less token

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 52591e7

This pull request introduces a new interface ComponentToken for defining component-specific style tokens, and applies it to the badge component. It also updates the theme interface and the migration document for the badge component to reflect the new tokens.

🔍 Walkthrough

🤖 Generated by Copilot at 52591e7

  • Introduce ComponentToken interface for badge style and remove unused or redundant tokens from BadgeToken interface (link, link)
  • Use component tokens instead of badge tokens for badge count, text, and dot elements (link, link, link, link)
  • Import ComponentToken interface to theme interface module and map it to Badge key in ComponentTokenMap interface (link, link)
  • Add badge section in migration document and list replaced less variables with comments and notes (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

@Wxh16144 Wxh16144 mentioned this pull request Jun 1, 2023
51 tasks
@codecov
Copy link

codecov bot commented Jun 1, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (db07a2f) 100.00% compared to head (628cec6) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42778   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          663       663           
  Lines        11271     11266    -5     
  Branches      3047      3047           
=========================================
- Hits         11271     11266    -5     
Files Changed Coverage Δ
components/badge/style/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wxh16144 Wxh16144 marked this pull request as draft June 2, 2023 03:05
@Wxh16144 Wxh16144 changed the title feat(badge): migrate less to token (skip ci) feat(badge): migrate less to token Jun 6, 2023
@Wxh16144 Wxh16144 marked this pull request as ready for review June 6, 2023 12:37
@Wxh16144

This comment was marked as resolved.

@argos-ci
Copy link

argos-ci bot commented Aug 14, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 2 changes Aug 14, 2023, 8:53 AM

@MadCcc MadCcc merged commit 6a6f1b7 into ant-design:feature Aug 14, 2023
51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants