Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Collapse): solve deprecated warning display unexpected in collapse issue #42876

Merged
merged 3 commits into from Jun 7, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Jun 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #42873

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English solve deprecated warning display unexpected in collapse issue
🇨🇳 Chinese 解决折叠面板组件废弃警告异常显示问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 6d0567e

Fixed a bug in the Collapse component that caused an empty array to be rendered when children was null. Added a test case for the new items prop feature and improved the code style of the test file.

🔍 Walkthrough

🤖 Generated by Copilot at 6d0567e

  • Fix bug that rendered empty array when children was undefined or null in Collapse component (link)
  • Add support for items prop in Collapse component as an alternative to children prop (link, link)
  • Reorder imports in index.test.tsx file to follow alphabetical order of module names (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

Pull reviewers stats

Stats of the last 30 days for ant-design:

User Total reviews Time to review Total comments
afc163 97 1h 18m 84
li-jia-nan 95 2h 82
MadCcc 57 1d 22h 34m 125
kiner-tang 52 20m 28
yoyo837 33 42m 33
zombieJ 30 2h 32m 25
RedJue 10 3h 50m 15
heiyu4585 2 30m 0
RexSkz 2 48m 5
BoyYangzai 2 17m 6
PeachScript 1 29m 0
vagusX 1 1h 36m 0
Wxh16144 1 21m 3
any1024 1 7h 10m 2
sawadyecma 1 1h 51m 2
bombillazo 1 23h 49m 1
lke-twh 1 2h 49m 0

@github-actions
Copy link
Contributor

github-actions bot commented Jun 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 375.84 KB (+4 B 🔺)
./dist/antd-with-locales.min.js 435.18 KB (+3 B 🔺)

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d36e303) 100.00% compared to head (3554d27) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #42876   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       646    -2     
  Lines        10955     10927   -28     
  Branches      2974      2967    -7     
=========================================
- Hits         10955     10927   -28     
Impacted Files Coverage Δ
components/collapse/Collapse.tsx 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 5ff95e3 into master Jun 7, 2023
86 checks passed
@afc163 afc163 deleted the fix-collapse-deprecated-wraning branch June 7, 2023 02:03
@MadCcc MadCcc mentioned this pull request Jun 7, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse with items still warns "children will be removed in next major version. Please use items instead."
2 participants