feat(Anchor): allow replacing in anchor #43006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kiner-tang
changed the title
kiner-tang
reviewed
Jun 14, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43006 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 649 650 +1
Lines 10936 10956 +20
Branches 2965 2971 +6
=========================================
+ Hits 10936 10956 +20
☔ View full report in Codecov by Sentry. |
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
|
The coverage is down, need fix it. |
It's because of the default |
kiner-tang
reviewed
Jun 18, 2023
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
Co-authored-by: kiner-tang(文辉) <1127031143@qq.com>
kiner-tang
approved these changes
Jun 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
The Anchor component should allow user to replace each item's href in browser history, because there are situations where we need a back button to take user to previous page, but currently when user clicks the back button he's sent back to the previous selected item in Anchor.
📝 Changelog
replacepropreplace属性☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 343684e
Added a new
replacefeature to theAnchorandAnchorLinkcomponents to allow users to choose the history mode for the anchor navigation. Updated the documentation and demo code in both English and Chinese languages to reflect the new feature. Reordered some imports to follow the code style guidelines.🔍 Walkthrough
🤖 Generated by Copilot at 343684e
replaceprop toAnchorandAnchorLinkcomponents to control history behavior (link, link, link, link, link, link)handleClickfunction inAnchorLinkcomponent to usewindow.location.replacemethod ifreplaceis true (link)replace.mdandreplace.tsxfiles to provide documentation and code example for the new feature (link, link)index.en-US.mdandindex.zh-CN.mdfiles to include the new feature in theExamples,Anchor PropsandAnchorItemsections (link, link, link, link, link, link)Anchor.tsxandAnchorLink.tsxfiles to follow code style guidelines (link, link)