fix: avoid shaking in typography by check widths whether is repeat #43039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43039 +/- ##
===========================================
- Coverage 100.00% 99.99% -0.01%
===========================================
Files 648 648
Lines 10953 10967 +14
Branches 2972 2975 +3
===========================================
+ Hits 10953 10966 +13
- Misses 0 1 +1
☔ View full report in Codecov by Sentry. |
zombieJ
reviewed
Jun 15, 2023
| if (clearTimer) clearTimeout(clearTimer); | ||
|
|
||
| clearTimer = setTimeout(() => { | ||
| historyWidthsMap.clear(); |
There was a problem hiding this comment.
有点黑，这个看起来对于同时多个 Ellipsis 会出现冲突，比如 Table 的场景
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
fix #42958
💡 Background and solution
avoid shaking in typography by check widths whether is repeat
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e714258
Improved typography ellipsis performance by skipping unnecessary state updates. Added
getHistoryWidthsMapCheckerfunction and reordered imports incomponents/typography/Base/index.tsx.🔍 Walkthrough
🤖 Generated by Copilot at e714258