Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: fix InputNumber prefix style in Form.Item #43048

Merged
merged 5 commits into from
Jun 16, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jun 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #35249

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix InputNumber with prefix abnormal height under Form.Item of hasFeedBack.
🇨🇳 Chinese 修复带 prefix InputNumber 在 Form.Item hasFeedBack 内高度异常的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b45dae0

This pull request improves the styling and layout of the InputNumber and Input.Group components, by adding or modifying the display property for their wrapper elements. It also updates the documentation and example code to demonstrate the usage and appearance of these components.

🔍 Walkthrough

🤖 Generated by Copilot at b45dae0

  • Add display: inline-block property to .ant-input-affix-wrapper and .ant-input-number classes to prevent collapsing or expanding of input elements with prefix or suffix icons (link, link)
  • Modify display: inline-block property to display: inline-flex for the direct children of .ant-input-group class to improve responsiveness and compatibility of input group component (link)
  • Update group.md example code to show how to use prefix icon for InputNumber component in input group (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 281.85 KB
./dist/antd.min.css 66.31 KB (+10 B 🔺)
./dist/antd.dark.min.css 67.55 KB (+9 B 🔺)
./dist/antd.compact.min.css 66.26 KB (+8 B 🔺)
./dist/antd.variable.min.css 66.85 KB (+9 B 🔺)

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (0463c1a) 100.00% compared to head (973b64c) 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           4.x-stable    #43048   +/-   ##
============================================
  Coverage      100.00%   100.00%           
============================================
  Files             450       450           
  Lines            8343      8343           
  Branches         2539      2539           
============================================
  Hits             8343      8343           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 changed the title style: Fix InputNumber prefix style in Form.Item style: fix InputNumber prefix style in Form.Item Jun 16, 2023
@afc163 afc163 force-pushed the style/input-number-prefix branch from 39d4808 to b055822 Compare June 16, 2023 07:58
@afc163 afc163 merged commit fb4ef43 into 4.x-stable Jun 16, 2023
93 checks passed
@afc163 afc163 deleted the style/input-number-prefix branch June 16, 2023 10:54
@MadCcc MadCcc mentioned this pull request Jun 27, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants