Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Modal defaultFooter Button disabled logic #43055

Merged
merged 8 commits into from Aug 10, 2023

Conversation

Wxh16144
Copy link
Member

@Wxh16144 Wxh16144 commented Jun 16, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix: #43044

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English update Modal defaultFooter Button disabled logic
🇨🇳 Chinese 更新 Modal 默认页脚禁用逻辑

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 07ec788

Fix a bug where Modal component would be disabled inside a Form component. Add a test suite for Modal in Form context.

🔍 Walkthrough

🤖 Generated by Copilot at 07ec788

  • Wrap ModalFooter component with DisabledContextProvider to prevent inheriting disabled prop from ancestors (link, link)
  • Import Form component and its props type from ../../form to use in new test suite for Modal in Form context (link)
  • Add new test suite to check that Modal does not disable its footer buttons when rendered inside a Form with disabled prop (link)
  • Import DisabledContextProvider component from ../config-provider/DisabledContext to use in ModalFooter (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 16, 2023

@argos-ci
Copy link

argos-ci bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 17, 2023, 9:17 AM

@zombieJ zombieJ merged commit da35a10 into ant-design:master Aug 10, 2023
50 checks passed
@MadCcc MadCcc mentioned this pull request Aug 10, 2023
20 tasks
@PeachScript PeachScript mentioned this pull request Aug 11, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants