New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Image): imageRender、toolbarRender、onTransform、items、minScale、max… #43075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎
Footnotes |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## feature #43075 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 650 650
Lines 10956 10979 +23
Branches 2971 2976 +5
=========================================
+ Hits 10956 10979 +23
☔ View full report in Codecov by Sentry. |
linxianxi
commented
Jun 20, 2023
zombieJ
reviewed
Jun 21, 2023
zombieJ
reviewed
Jun 21, 2023
zombieJ
approved these changes
Jun 21, 2023
MadCcc
approved these changes
Jun 21, 2023
Closed
This was referenced May 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#42845
#27273
#38418
react-component/image#192
react-component/image#110
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 34cfae4
This pull request enhances the image component with new features, props, and demos, and updates the documentation and dependency accordingly. It adds the ability to customize the preview and toolbar render, to pass an array of preview sources to the preview group, and to render a video instead of an image in the preview. It also fixes some style and functionality issues of the preview feature, and some typos and inconsistencies in the documentation. It modifies the files
components/image/*
, andpackage.json
.🔍 Walkthrough
🤖 Generated by Copilot at 34cfae4
items
prop to pass an array of preview sources to theImage.PreviewGroup
component (link)Image
component API in the English and Chinese documentation (link, link)preview
prop in theImage
component API frompreviewType
toPreviewType
in the English and Chinese documentation, to match the naming convention of the other types (link, link)previewType
section in the English and Chinese documentation, and add the detailed descriptions and versions for each prop in thePreviewType
,PreviewGroupType
,TransformType
,TransformAction
, andToolbarRenderType
interfaces (link, link)imageRender
,onTransform
,minScale
, andmaxScale
to thePreviewType
andPreviewGroupType
interfaces, and the new propcurrent
to theimageRender
parameter in thePreviewType
interface, to support custom preview render and transform events in the image component (link, link)pointerEvents
andtransition
properties from the wrapper, and move thepointerEvents
property to the content itself, to avoid blocking the mouse events on the custom preview content (link, link)rc-image
package from5.17.1
to5.18.1
, to use the latest features and bug fixes of the image component (link)