Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button disabled style with link or href case #43091

Merged
merged 8 commits into from Jun 30, 2023

Conversation

BoyYangzai
Copy link
Contributor

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English fix: Button disabled style with link or href case
🇨🇳 Chinese 修复 Button 在有 link or href 属性时禁用样式错误

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

@BoyYangzai BoyYangzai changed the title Fix button dieabled fix: Button disabled style with link or href case Jun 19, 2023
@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6cbf3e1) 100.00% compared to head (cde3885) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43091   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10965     10966    +1     
  Branches      2978      2977    -1     
=========================================
+ Hits         10965     10966    +1     
Impacted Files Coverage Δ
components/button/button.tsx 100.00% <ø> (ø)
components/button/style/index.ts 100.00% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

afc163
afc163 previously requested changes Jun 22, 2023
Copy link
Member

@afc163 afc163 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

看下 lint 问题

Co-authored-by: Wuxh <wxh16144@qq.com>
@MadCcc MadCcc merged commit cb338a2 into ant-design:master Jun 30, 2023
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

button type = 'link' 并且禁用的情况下 样式问题
4 participants