Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: update unknown with SliderRef #43094

Merged
merged 1 commit into from Jun 19, 2023
Merged

type: update unknown with SliderRef #43094

merged 1 commit into from Jun 19, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jun 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English type: update unknown with SliderRef
🇨🇳 Chinese unknown 更新为 SliderRef 类型

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 8fd36dc

Improve type and debug support for SliderTooltip component. Use SliderRef type for ref and add displayName in development mode.

🔍 Walkthrough

🤖 Generated by Copilot at 8fd36dc

  • Annotate the ref parameter of the SliderTooltip component with the SliderRef type imported from rc-slider (link,link)
  • Add a displayName property to the SliderTooltip component for debugging and testing purposes, and wrap it in a conditional statement to only include it in development mode (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 19, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 376.7 KB
./dist/antd-with-locales.min.js 436.13 KB

@codecov
Copy link

codecov bot commented Jun 19, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (feb8c56) 100.00% compared to head (8fd36dc) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43094   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10955     10957    +2     
  Branches      2974      2975    +1     
=========================================
+ Hits         10955     10957    +2     
Impacted Files Coverage Δ
components/slider/SliderTooltip.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit 33fab22 into master Jun 19, 2023
95 checks passed
@afc163 afc163 deleted the slider-type branch June 19, 2023 09:07
@PeachScript PeachScript mentioned this pull request Jun 25, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants