fix slider component disabled status in form #43142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zombieJ
reviewed
Jun 21, 2023
| @@ -114,6 +116,8 @@ const Slider = React.forwardRef<SliderRef, SliderSingleProps | SliderRangeProps> | |||
| } = props; | |||
|
|
|||
| const { getPrefixCls, direction, getPopupContainer } = React.useContext(ConfigContext); | |||
| const contextDisabled = React.useContext(DisabledContext); | |||
There was a problem hiding this comment.
Could you help to add test case about this?
There was a problem hiding this comment.
Test case和页面demo有重叠，所以我同时改动了demo。
如果这影响到了发布规范，我可以撤销有关demo的改动。
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #43142 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 648 648
Lines 10963 10965 +2
Branches 2976 2977 +1
=========================================
+ Hits 10963 10965 +2
☔ View full report in Codecov by Sentry. |
afc163
approved these changes
Jun 24, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
#43140
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 5dd6cb3
Enhanced
Slidercomponent to support disabling functionality. AddedDisabledContextanddisabledprop tocomponents/slider/index.tsx.🔍 Walkthrough
🤖 Generated by Copilot at 5dd6cb3
disabledprop toSlidercomponent to allow manual disabling (link)DisabledContextto get the disabled state from the parent component (link, link)disabledprop and theDisabledContextvalue to determine the final disabled state of the slider (link, link)rc-slidercomponent (link)