Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Breadcrumb): items dropdownProps loss #43151

Merged
merged 3 commits into from Jun 22, 2023

Conversation

linxianxi
Copy link
Contributor

@linxianxi linxianxi commented Jun 22, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #43146

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fixed invalid dropdownProps for items
🇨🇳 Chinese 修复 items dropdownProps 无效的问题

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 3a8ec93

Added a new prop dropdownProps to Breadcrumb component to allow customizing the Dropdown menu. Updated the overlay demo to show an example of using the new prop.

🔍 Walkthrough

🤖 Generated by Copilot at 3a8ec93

  • Add dropdownProps property to BreadcrumbItemType interface and pass it to Dropdown component in Breadcrumb component (link, link, link, link)
  • Remove redundant assignment of itemClassName to itemProps.className in Breadcrumb component (link)
  • Change import order and add dropdownProps to last breadcrumb item in overlay.tsx demo (link, link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 22, 2023

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (6b4afc9) 100.00% compared to head (8cc1bc5) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43151   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10960     10961    +1     
  Branches      2975      2975           
=========================================
+ Hits         10960     10961    +1     
Impacted Files Coverage Δ
components/breadcrumb/Breadcrumb.tsx 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Jun 22, 2023

加个用例?

@linxianxi
Copy link
Contributor Author

加个用例?

done

@afc163 afc163 merged commit 7a7ee61 into ant-design:master Jun 22, 2023
52 checks passed
@PeachScript PeachScript mentioned this pull request Jun 25, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

面包屑导航使用 items 渲染时,下拉菜单能展示箭头吗?
2 participants