Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move colorLink to seedToken #43183

Merged
merged 2 commits into from Jun 26, 2023
Merged

feat: move colorLink to seedToken #43183

merged 2 commits into from Jun 26, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jun 26, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Move colorLink to seed token, colorLinkHover and colorLinkActive will be calculated with colorLink.
🇨🇳 Chinese colorLink 添加至 seed token 中, colorLinkHovercolorLinkActive 将会由 colorLink 计算得出。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 387f9fe

This pull request adds support for hyperlink colors in the theme system. It introduces a new colorLink token and its related interfaces and functions. It also removes unused and redundant properties from the alias token and updates the token tests.

🔍 Walkthrough

🤖 Generated by Copilot at 387f9fe

  • Add ColorLinkMapToken interface to define hyperlink colors (link,link)
  • Extend ColorMapToken interface with ColorLinkMapToken interface (link)
  • Remove colorLink, colorLinkHover, and colorLinkActive properties from AliasToken interface (link)
  • Remove colorLink, colorLinkHover, and colorLinkActive properties from alias token object (link)
  • Add colorLink property to SeedToken interface with default value of colorPrimary (link)
  • Add colorLink property to seedToken value with empty string (link)
  • Generate colorLink token based on colorLink or colorPrimary seed value (link)
  • Add colorLinkHover, colorLink, and colorLinkActive properties to color map token object (link)
  • Add test suite for colorLink token in token.test.tsx (link)
  • Move getHookToken helper function to the top of token.test.tsx (link,link)
  • Add blank line to alias.ts for formatting (link)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jun 26, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 378.26 KB (+13 B 🔺)
./dist/antd-with-locales.min.js 437.62 KB (+13 B 🔺)

@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (9757df0) 100.00% compared to head (387f9fe) 100.00%.

❗ Current head 387f9fe differs from pull request most recent head 32a69d8. Consider uploading reports for the commit 32a69d8 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43183   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          654       654           
  Lines        10999     11001    +2     
  Branches      2982      2983    +1     
=========================================
+ Hits         10999     11001    +2     
Impacted Files Coverage Δ
components/theme/themes/seed.ts 100.00% <ø> (ø)
components/theme/util/alias.ts 100.00% <ø> (ø)
components/theme/themes/shared/genColorMapToken.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc merged commit 3589050 into feature Jun 26, 2023
88 checks passed
@MadCcc MadCcc deleted the feat/seed-color-link branch June 26, 2023 03:23
@phoema
Copy link

phoema commented Jul 26, 2023

原来没有colorLink这个属性吗,超链接跟随主题色,现在必须设置此属性吗,不然默认#1677ff,也不再跟随主题色?

@phoema
Copy link

phoema commented Jul 26, 2023

Add colorLink property to SeedToken interface with default value of colorPrimary (link)
是否是这个测试用例没通过?

@MadCcc
Copy link
Member Author

MadCcc commented Aug 9, 2023

Add colorLink property to SeedToken interface with default value of colorPrimary (link) 是否是这个测试用例没通过?

Copilot 生成的 AI 描述,不会响应后续的 commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants