Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(Progress): support animation in rtl direction #43316

Merged
merged 1 commit into from Jul 3, 2023

Conversation

Yuiai01
Copy link
Contributor

@Yuiai01 Yuiai01 commented Jul 1, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #43312

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Progress support animation in rtl direction
🇨🇳 Chinese progress 支持 rtl 方向的动画

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at b313356

Added RTL support for progress animation by creating a keyframe generator function and applying it to the style rules. Refactored the imports in components/progress/style/index.tsx.

🔍 Walkthrough

🤖 Generated by Copilot at b313356

  • Reorder import statements to group related modules and follow convention (link)
  • Add genAntProgressActive function to generate different keyframes for RTL and LTR directions (link)
  • Update animationName property to use genAntProgressActive function with default LTR direction (link)
  • Add style rule for progress component with rtl and status-active modifiers to use genAntProgressActive function with RTL direction (link)

@stackblitz
Copy link

stackblitz bot commented Jul 1, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 1, 2023

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e2907c8) 100.00% compared to head (b313356) 100.00%.

❗ Current head b313356 differs from pull request most recent head 6eb26b2. Consider uploading reports for the commit 6eb26b2 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43316   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10967     10967           
  Branches      2978      2978           
=========================================
  Hits         10967     10967           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163
Copy link
Member

afc163 commented Jul 3, 2023

lint 挂了

@Yuiai01
Copy link
Contributor Author

Yuiai01 commented Jul 3, 2023

lint 挂了

好,我整一下

@afc163 afc163 merged commit b46c2d0 into ant-design:master Jul 3, 2023
50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress RTL - wrong animation in active state
2 participants