feat: ColorPicker implement disabledAlpha API
#43355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
kiner-tang
approved these changes
Jul 4, 2023
size-limit report 📦
|
|
ci 挂了 |
|
好像是 cssinjs 那个问题搞挂的 |
在看了👌 |
RedJue
force-pushed
the
color-picker-disabled-alpha
branch
from
0f80144
to
8f0958a
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43355 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 11162 11077 -85
Branches 3029 2998 -31
=========================================
- Hits 11162 11077 -85
☔ View full report in Codecov by Sentry. |
|
如果用户传了一个带透明度的颜色，会不会帮用户把透明度去掉？ |
代码里没做限制，感觉需要做一下限制，因为可能有复合使用的场景，我补充一下。 |
li-jia-nan
approved these changes
Jul 7, 2023
|
Conflicting |
RedJue
force-pushed
the
color-picker-disabled-alpha
branch
from
8f0958a
to
bb1f44f
Compare
20 tasks
处理的时候应该把透明度变为 1，并且给出警告 |
ok 我加一下 |
RedJue
force-pushed
the
color-picker-disabled-alpha
branch
from
7f6a40b
to
7382b0f
Compare
RedJue
force-pushed
the
color-picker-disabled-alpha
branch
from
7382b0f
to
afbcb28
Compare
|
Conflicting |
RedJue
changed the title
disabledAlpha API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
disabledAlphaprop does not work #43253💡 Background and solution
📝 Changelog
disabledAlphaAPIdisabledAlphaAPI☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 0f80144
Added a new feature to the
ColorPickercomponent to allow disabling the alpha channel of the color picker. This feature is controlled by a new propdisabledAlphathat is passed to theColorPickerand its subcomponents. Updated the documentation, demo, styles, and tests to reflect this change.🔍 Walkthrough
🤖 Generated by Copilot at 0f80144
disabledAlphaprop toColorPickercomponent and its subcomponents to allow users to disable the alpha channel of the color picker (link, link, link, link, link)disabledAlphaprop toRcColorPickerPanelandColorInputcomponents inPanelPickercomponent to disable the alpha slider and input in the panel and the input box (link, link)disabledAlphaprop from thepropsobject inColorPicker,PanelPicker, andColorInputcomponents to use it later (link, link, link)ColorInputcomponent to hide theColorAlphaInputcomponent if thedisabledAlphaprop is true (link)genPickerStylefunction to avoid overlapping and create some space between the sliders and the input box (link, link)disabledAlphamodifier to adjust the layout of the sliders when the alpha slider is disabled (link)disabledAlphaprop works as expected in theColorPickercomponent (link)ColorPickerdocumentation in Chinese and English to describe thedisabledAlphaprop (link, link, link, link)disabledAlphaprop from theColorPickerPropstype to avoid passing it to the underlyingRcColorPickercomponent, which does not support it (link)