Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tag position of wave #43402

Merged
merged 1 commit into from Jul 6, 2023
Merged

fix: tag position of wave #43402

merged 1 commit into from Jul 6, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #43400

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Tag wave effect some time not fire on Tag element.
🇨🇳 Chinese 修复 Tag 点击的水波纹效果有时候会和 Tag 元素产生偏移的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 3d88892

Fix tag close icon overlap issue by adding relative position to tag style. Update components/tag/style/index.ts file.

🔍 Walkthrough

🤖 Generated by Copilot at 3d88892

  • Fix tag close icon overlap issue by adding position: relative to tag base style ([link](https://github.com/ant-design/ant-design/pull/43402/files?diff=unified&w=0#diff-cb2262b77ae285e7da02504971f378bec871797a530abbf2a34f14fdb3d92f85R91))

@stackblitz
Copy link

stackblitz bot commented Jul 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 377.3 KB (+1 B 🔺)
./dist/antd-with-locales.min.js 436.76 KB (+1 B 🔺)

@codecov
Copy link

codecov bot commented Jul 6, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (749aea0) 100.00% compared to head (3d88892) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43402   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          648       648           
  Lines        10967     10967           
  Branches      2978      2978           
=========================================
  Hits         10967     10967           
Impacted Files Coverage Δ
components/tag/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit a7f14e7 into master Jul 6, 2023
95 checks passed
@zombieJ zombieJ deleted the fix-tag branch July 6, 2023 06:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

点击Tag,水波纹错位
3 participants