feat: Modal hooks confirm function support await #43470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
size-limit report 📦
|
li-jia-nan
approved these changes
Jul 10, 2023
MadCcc
approved these changes
Jul 11, 2023
afc163
reviewed
Jul 11, 2023
|
|
||
| ```tsx | ||
| //点击 `onOk` 时返回 `true`，点击 `onCancel` 时返回 `false` | ||
| const confirmed = await modal.confirm({ ... }); |
Wxh16144
pushed a commit
to Wxh16144-forks/ant-design
that referenced
this pull request
Jul 12, 2023
* docs: move demo to useModal * docs: reorder * chore: update ts def * test: test case * chore: fix compile
crazyair
reviewed
Aug 7, 2023
| then<T>(resolve: (confirmed: boolean) => T, reject: VoidFunction): Promise<T>; | ||
| }; | ||
|
|
||
| export type HookAPI = Omit<Record<keyof ModalStaticFunctions, ModalFuncWithPromise>, 'warn'>; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
ref #43295
💡 Background and solution
📝 Changelog
awaitcall.await调用。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at e7e0285
This pull request enhances the modal component and its hooks method, by adding new props and features. It allows the modal to optionally suppress error messages, return a promise with the user's choice, and customize the close behavior. It also updates the demo code, the tests, and the documentation for the modal component in both English and Chinese. It mainly affects the files
components/modal/*,components/_util/ActionButton.tsx, andcomponents/modal/demo/hooks.md.🔍 Walkthrough
🤖 Generated by Copilot at e7e0285
isSilentprop toActionButtonandConfirmDialogcomponents to control error throwing behavior (link, link, link, link, link, link, link)onCloseprop toConfirmDialogandHookModalcomponents to supportawaitoperation for hooks method of modal (link, link, link, link, link, link, link)useModalhook to return modal functions withthenfield that returns a promise that resolves with confirmed value (link, link, link, link, link, link, link)hooks.tsxdemo code to useasyncandawaitkeywords and log confirmed value (link, link, link)hook.test.tsxfile to add test case forawaitoperation (link)hooks.md,index.en-US.md,index.zh-CN.md) to explainawaitoperation and link to relevant demo codes (link, link, link, link, link, link, link)