Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove the default value of the empty string #43481

Merged
merged 1 commit into from Jul 11, 2023

Conversation

thinkasany
Copy link
Contributor

@thinkasany thinkasany commented Jul 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  1. className 都是可选类型 可以是undefined不需要给默认值

image
2. classNames 函数的参数列表中包括了空字符串 '',但是它会被忽略

📝 Changelog

Language Changelog
🇺🇸 English Remove the default value of the empty string
🇨🇳 Chinese 去掉空字符串的默认值

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 47f72cb

This pull request refactors some components to simplify code and follow import conventions. It also removes unnecessary default values of className props in Anchor and CollapsePanel components.

🔍 Walkthrough

🤖 Generated by Copilot at 47f72cb

  • Remove default values of className prop in Anchor, CollapsePanel, and Group components to simplify code and avoid conflicts (link, link, link)
  • Reorder import statements in Group component to follow convention of React and hooks first, then external modules, then internal modules (link)

@stackblitz
Copy link

stackblitz bot commented Jul 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

@yoyo837 yoyo837 merged commit bbfaa9a into ant-design:master Jul 11, 2023
55 checks passed
@vagusX vagusX mentioned this pull request Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants