Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Descriptions implement items API #43483

Merged
merged 8 commits into from Jul 17, 2023

Conversation

RedJue
Copy link
Member

@RedJue RedJue commented Jul 11, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Descriptions implement items API, and updating the demo usage.
🇨🇳 Chinese 描述列表实现 items API,同时更新 demo 用法 。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at c304aab

This pull request adds a new items prop to the Descriptions component that allows users to pass an array of DescriptionsItem objects instead of using children elements. It also updates the documentation and the demo code to reflect the new feature and deprecates the children prop.

🔍 Walkthrough

🤖 Generated by Copilot at c304aab

  • Add a new items prop to the Descriptions component and deprecate the children prop (link, link, link, link, link, link)
  • Document the new items prop and its usage in both English and Chinese (link, link, link, link)
  • Refactor the demo code to use the new items prop instead of the children prop in basic.tsx, border.tsx, component-token.tsx, responsive.tsx, size.tsx, style.tsx, text.tsx, and vertical-border.tsx (link, link, link, link, link, link, link, link, link, link, link, link, link, link, link, link)
  • Add a new test case for the items prop in index.test.tsx (link)

@stackblitz
Copy link

stackblitz bot commented Jul 11, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@RedJue RedJue requested a review from zombieJ July 11, 2023 07:42
@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 11, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 381.7 KB (+91 B 🔺)
./dist/antd-with-locales.min.js 441.33 KB (+86 B 🔺)

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3e5a392) 100.00% compared to head (d470880) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43483   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       658    +1     
  Lines        11162     11089   -73     
  Branches      3029      3000   -29     
=========================================
- Hits         11162     11089   -73     
Impacted Files Coverage Δ
components/affix/index.tsx 100.00% <ø> (ø)
components/alert/index.ts 100.00% <ø> (ø)
components/anchor/index.ts 100.00% <ø> (ø)
components/app/index.tsx 100.00% <ø> (ø)
components/auto-complete/index.tsx 100.00% <ø> (ø)
components/avatar/index.ts 100.00% <ø> (ø)
components/back-top/index.tsx 100.00% <ø> (ø)
components/badge/index.tsx 100.00% <ø> (ø)
components/button/style/index.ts 100.00% <ø> (ø)
components/calendar/index.ts 100.00% <ø> (ø)
... and 71 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ mentioned this pull request Jul 11, 2023
20 tasks
components/descriptions/index.tsx Outdated Show resolved Hide resolved
components/descriptions/index.tsx Show resolved Hide resolved
components/descriptions/index.zh-CN.md Outdated Show resolved Hide resolved
components/descriptions/index.en-US.md Outdated Show resolved Hide resolved
@RedJue RedJue force-pushed the feature-descriptions-support-items branch from 09795f7 to 7b68fb7 Compare July 12, 2023 06:30
@RedJue RedJue force-pushed the feature-descriptions-support-items branch from de43b89 to b8f2e5d Compare July 13, 2023 02:36
RedJue and others added 8 commits July 17, 2023 10:49
Co-authored-by: Wuxh <wxh1220@gmail.com>
Signed-off-by: 红果汁 <pingfj77@gmail.com>
Co-authored-by: Wuxh <wxh1220@gmail.com>
Signed-off-by: 红果汁 <pingfj77@gmail.com>
Co-authored-by: Wuxh <wxh1220@gmail.com>
Signed-off-by: 红果汁 <pingfj77@gmail.com>
@RedJue RedJue force-pushed the feature-descriptions-support-items branch from b8f2e5d to d470880 Compare July 17, 2023 02:50
@argos-ci
Copy link

argos-ci bot commented Jul 17, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 3 changes Jul 17, 2023, 3:16 AM

@zombieJ zombieJ merged commit ecb3684 into feature Jul 17, 2023
87 checks passed
@zombieJ zombieJ deleted the feature-descriptions-support-items branch July 17, 2023 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants