New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changed import type to common import #43501
Conversation
Run & review this pull request in StackBlitz Codeflow. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #43501 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 657
Lines 11045 11045
Branches 2989 2989
=========================================
Hits 11045 11045
☔ View full report in Codecov by Sentry. |
原因是啥? |
Exporting a context object as a type is wrong, it will not be possible to use it in React.useContext because of this. |
看了一下这个没啥问题, |
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
When transferring the context to a separate file, the type export was used, not the usual export.
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 0ba58f5
Refactor
Space
component and its context to improve consistency and performance. ChangeSpaceContext
from a type export to a named export incomponents/space/index.tsx
.🔍 Walkthrough
🤖 Generated by Copilot at 0ba58f5
Space
component to useReact.Children.toArray
andReact.cloneElement
instead of custom logic to handle children and gaps (- - - - - - - - - - - - - - -F0L