refactor: Select deprecated showArrow prop #43520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
MuxinFeng
changed the title
|
Updated and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: rc-select@14.5.2, rc-tree-select@5.9.0 |
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43520 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 657 658 +1
Lines 11077 11091 +14
Branches 2998 2998
=========================================
+ Hits 11077 11091 +14
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
Jul 17, 2023
components/select/index.tsx
Outdated
| @@ -131,7 +136,7 @@ const InternalSelect = < | |||
| }, [props.mode]); | |||
|
|
|||
| const isMultiple = mode === 'multiple' || mode === 'tags'; | |||
| const mergedShowArrow = useShowArrow(showArrow); | |||
| const showSuffixIcon = useShowArrow(props.suffixIcon); | |||
There was a problem hiding this comment.
要兼容 showArrow，留个 test case 保证废弃的 api 也有效
MadCcc
reviewed
Jul 17, 2023
components/select/index.tsx
Outdated
| @@ -221,6 +227,12 @@ const InternalSelect = < | |||
| 'Select', | |||
| '`dropdownMatchSelectWidth` is deprecated. Please use `popupMatchSelectWidth` instead.', | |||
| ); | |||
|
|
|||
| warning( | |||
| showArrow === undefined, | |||
There was a problem hiding this comment.
Suggested change
| showArrow === undefined, | |
| !('showArrow' in props), |
MadCcc
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
Select&Tree-Select&Cascadercomponent deprecatedshowArrowpropSelect&Tree-Select&Cascader组件废弃showArrow属性☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at c983312
This pull request refactors the
Selectcomponent to use thesuffixIconprop instead of theshowArrowandinputIconprops. This simplifies the API and allows more customization of the select appearance. It also updates the demos and the documentation to reflect the new prop name and default value.🔍 Walkthrough
🤖 Generated by Copilot at c983312
showArrowprop and replace it withsuffixIconprop inSelectcomponent and related components (link, link, link, link, link, link, link, link, link, link, link, link, link)showArrowprop fromSelectcomponent incustom-tag-renderdemo and update documentation to reflect default value ofsuffixIconprop (link, link, link)showArrowprop inInternalSelectPropsinterface incomponents/select/index.tsx(link)mergedShowArrowvariable toshowSuffixIconand changeuseShowArrowhook to acceptsuffixIconprop inInternalSelectvalue or function incomponents/select/index.tsx(link)showArrowprop withshowSuffixIconprop inuseSelecthook call andRcSelectcomponent call inInternalSelectvalue or function incomponents/select/index.tsx(link, link, link)useShowArrowhook logic to returntrueifsuffixIconprop is notnullincomponents/select/useShowArrow.ts(link)showArrowprop toshowSuffixIconprop and replace it withshowSuffixIconprop ingetSuffixIconNodefunction call iniconUtilfunction incomponents/select/utils/iconUtil.tsx(link, link, link)inputIconprop fromSelectPropsinterface andRcSelectcomponent call incomponents/select/index.tsx(link, link)showArrowprop withsuffixIconprop set tonullto hide arrow icon inSelectcomponent insearch-boxdemo (link)