Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Indeterminate & checked style #43626

Merged
merged 1 commit into from Jul 18, 2023
Merged

fix: Indeterminate & checked style #43626

merged 1 commit into from Jul 18, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

fix #43621

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Checkbox both set checked & indeterminate prop will not show as indeterminate style.
🇨🇳 Chinese 修复 Checkbox 同时配置 checkedindeterminate 时没有展示为 indeterminate 样式的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at d246971

Refactor checkbox component to use design tokens for indeterminate state. This improves the consistency and maintainability of the component's style.

🔍 Walkthrough

🤖 Generated by Copilot at d246971

  • Refactor the checkbox component to use design tokens for styling (link, link)
    • Remove the hard-coded background color and border color of the checkbox inner element when the checkbox is in the indeterminate state (link)
    • Add the background color and border color of the checkbox inner element when the checkbox is in the indeterminate state, using the design tokens token.colorBgContainer and token.colorBorder (link)

@stackblitz
Copy link

stackblitz bot commented Jul 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 381.65 KB (-1 B 🔽)
./dist/antd-with-locales.min.js 441.26 KB (-3 B 🔽)

@argos-ci
Copy link

argos-ci bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 18, 2023, 12:00 PM

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (cf40fb0) 100.00% compared to head (d246971) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43626   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       657           
  Lines        11064     11064           
  Branches      2999      2999           
=========================================
  Hits         11064     11064           
Impacted Files Coverage Δ
components/checkbox/style/index.ts 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit ca9c7c7 into master Jul 18, 2023
95 checks passed
@zombieJ zombieJ deleted the fix-checkbox branch July 18, 2023 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Checkbox组件多选时样式重叠错乱
3 participants