Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Button ts #43629

Merged
merged 1 commit into from Jul 18, 2023
Merged

fix: Button ts #43629

merged 1 commit into from Jul 18, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 18, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #43608

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Adjust Button definition to correct handle onClick type.
🇨🇳 Chinese 调整 Button 类型以正确处理 onClick 定义。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 70500f8

This pull request refactors the button component to use a union type for the props, adds a new test case for the button type, and formats the PurePanel component with prettier. These changes aim to improve the type safety, test quality, and code style of the components.

🔍 Walkthrough

🤖 Generated by Copilot at 70500f8

  • Refactor the button component to use a union type instead of a partial type for the props, which improves the type safety and readability of the code (link, link, link, link in components/button/button.tsx)
  • Format the code in components/popconfirm/PurePanel.tsx to follow the prettier rules and improve the readability of the code (link)

@stackblitz
Copy link

stackblitz bot commented Jul 18, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 18, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 381.65 KB (+7 B 🔺)
./dist/antd-with-locales.min.js 441.28 KB (+13 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Jul 18, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 18, 2023, 1:35 PM

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cf40fb0) 100.00% compared to head (70500f8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43629   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       657           
  Lines        11064     11067    +3     
  Branches      2999      2999           
=========================================
+ Hits         11064     11067    +3     
Impacted Files Coverage Δ
components/popconfirm/PurePanel.tsx 100.00% <ø> (ø)
components/button/button.tsx 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit a9bceec into master Jul 18, 2023
95 checks passed
@afc163 afc163 deleted the btn-type branch July 18, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Confusing Button.onClick type
3 participants