Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

type: use ValueType from rc-input-number #43635

Merged
merged 1 commit into from Jul 19, 2023
Merged

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Jul 19, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

解决一下 InputNumber 的幽灵依赖问题

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese -

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 9fee891

Updated rc-input-number dependency and fixed import of ValueType type. This improves the input number component and aligns with the dependency updates in pull request #33333.

🔍 Walkthrough

🤖 Generated by Copilot at 9fee891

  • Update the import of ValueType from rc-input-number instead of @rc-component/mini-decimal to match the new type definition (link)
  • Upgrade the rc-input-number dependency to ~8.0.2 to fix some issues and improve the performance of the InputNumber component (link)

@stackblitz
Copy link

stackblitz bot commented Jul 19, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 381.67 KB
./dist/antd-with-locales.min.js 441.29 KB

@argos-ci
Copy link

argos-ci bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ✅ No change detected - Jul 19, 2023, 2:06 AM

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fac39eb) 100.00% compared to head (9fee891) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43635   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          657       657           
  Lines        11064     11064           
  Branches      2999      2999           
=========================================
  Hits         11064     11064           
Impacted Files Coverage Δ
components/input-number/index.tsx 100.00% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@afc163 afc163 merged commit edd15aa into master Jul 19, 2023
95 checks passed
@afc163 afc163 deleted the chore/input-niumber-type branch July 19, 2023 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants