New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Transfer support custom dropdown Icon #43773
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
MadCcc
reviewed
Jul 25, 2023
MadCcc
reviewed
Jul 25, 2023
size-limit report 📦
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
kiner-tang
approved these changes
Jul 25, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43773 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11110 11112 +2
Branches 3006 3007 +1
=========================================
+ Hits 11110 11112 +2
☔ View full report in Codecov by Sentry. |
MadCcc
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 8964f93
This pull request adds a new feature to the
Transfer
component, which lets users customize the icon of the dropdown menu in the transfer list. It modifies theTransferList
component, the TypeScript definition file, and the API documentation in both English and Chinese.🔍 Walkthrough
🤖 Generated by Copilot at 8964f93
dropdownIcon
property toTransfer
andTransferList
components to allow customizing the dropdown icon of the transfer list header (link, link, link, link, link, link, link, link, link)isValidIcon
function inlist.tsx
to check if a given icon is valid for rendering (link)