Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Transfer support custom dropdown Icon #43773

Merged
merged 5 commits into from Jul 25, 2023
Merged

feat: Transfer support custom dropdown Icon #43773

merged 5 commits into from Jul 25, 2023

Conversation

li-jia-nan
Copy link
Member

@li-jia-nan li-jia-nan commented Jul 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English feat: Transfer support custom dropdown Icon
🇨🇳 Chinese Transfer 组件支持自定义 dropdown 下拉图标

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 8964f93

This pull request adds a new feature to the Transfer component, which lets users customize the icon of the dropdown menu in the transfer list. It modifies the TransferList component, the TypeScript definition file, and the API documentation in both English and Chinese.

🔍 Walkthrough

🤖 Generated by Copilot at 8964f93

  • Add dropdownIcon property to Transfer and TransferList components to allow customizing the dropdown icon of the transfer list header (link, link, link, link, link, link, link, link, link)
  • Define isValidIcon function in list.tsx to check if a given icon is valid for rendering (link)

@stackblitz
Copy link

stackblitz bot commented Jul 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 382.6 KB (+11 B 🔺)
./dist/antd-with-locales.min.js 442.15 KB (+13 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 3 changes Jul 25, 2023, 4:41 AM

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b4035b0) 100.00% compared to head (223c2ae) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43773   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11110     11112    +2     
  Branches      3006      3007    +1     
=========================================
+ Hits         11110     11112    +2     
Files Changed Coverage Δ
components/transfer/index.tsx 100.00% <ø> (ø)
components/transfer/list.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@li-jia-nan li-jia-nan requested a review from MadCcc July 25, 2023 03:47
@MadCcc MadCcc merged commit d34b4e1 into feature Jul 25, 2023
87 checks passed
@MadCcc MadCcc deleted the transfer-icon branch July 25, 2023 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants