Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Select aria-activedescendant didn't conform to valid value #43800

Merged
merged 1 commit into from Jul 26, 2023

Conversation

afc163
Copy link
Member

@afc163 afc163 commented Jul 25, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

react-component/select#966

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix Select aria-activedescendant didn't conform to valid value.
🇨🇳 Chinese 修复 Select aria-activedescendant 缺少有效值的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 13ea471

Updated rc-select dependency to fix a Select component bug. This is part of a pull request to upgrade dependencies and improve ant-design performance and compatibility.

🔍 Walkthrough

🤖 Generated by Copilot at 13ea471

  • Upgrade rc-select dependency to fix input focus bug in Select component (link)

@stackblitz
Copy link

stackblitz bot commented Jul 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@afc163 afc163 changed the base branch from master to feature July 25, 2023 12:03
@afc163 afc163 changed the title Fix/select aria activedescendant fix: Select aria-activedescendant didn't conform to valid value Jul 25, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

@socket-security
Copy link

socket-security bot commented Jul 25, 2023

No top level dependency changes detected. Learn more about Socket for GitHub ↗︎

@afc163 afc163 force-pushed the fix/select-aria-activedescendant branch from 13ea471 to f6924b2 Compare July 25, 2023 12:11
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 382.79 KB
./dist/antd-with-locales.min.js 442.35 KB

@argos-ci
Copy link

argos-ci bot commented Jul 25, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 3 changes Jul 25, 2023, 12:23 PM

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fcfbb9a) 100.00% compared to head (f6924b2) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43800   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11117     11118    +1     
  Branches      3010      3009    -1     
=========================================
+ Hits         11117     11118    +1     
Files Changed Coverage Δ
components/_util/motion.ts 100.00% <ø> (ø)
components/cascader/index.tsx 100.00% <ø> (ø)
components/float-button/FloatButtonGroup.tsx 100.00% <ø> (ø)
components/select/index.tsx 100.00% <ø> (ø)
components/tooltip/index.tsx 100.00% <ø> (ø)
components/tree-select/index.tsx 100.00% <ø> (ø)
components/select/style/dropdown.tsx 100.00% <100.00%> (ø)
components/watermark/index.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afc163 afc163 merged commit 2d3c979 into feature Jul 26, 2023
87 checks passed
@afc163 afc163 deleted the fix/select-aria-activedescendant branch July 26, 2023 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants