Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Form getFieldsValue support strict #43828

Merged
merged 1 commit into from Jul 27, 2023
Merged

feat: Form getFieldsValue support strict #43828

merged 1 commit into from Jul 27, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Jul 26, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

resolve #43300

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Form support getFieldsValue({ strict: true }) to support only Item bind values.
🇨🇳 Chinese Form 新增 getFieldsValue({ strict: true }) 以支持获取仅通过 Item 绑定的字段。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 4747ca8

This pull request enhances the documentation and functionality of the Form.List and FormInstance components. It updates the English and Chinese documentation files to reflect the usage and options of the getFieldsValue function, and it upgrades the rc-field-form dependency to support the strict option.

🔍 Walkthrough

🤖 Generated by Copilot at 4747ca8

  • Update the name prop of Form.List to clarify that it is also a field and its values can be controlled by the getFieldsValue config (link, link)
  • Replace the getFieldsValue prop of FormInstance with a link to the GetFieldsValue section that explains the overloaded methods and parameters of the function (link, link)
  • Add the GetFieldsValue section to the documentation of components/form/index.en-US.md and components/form/index.zh-CN.md to describe the different ways of using the getFieldsValue function of FormInstance, including the new strict option introduced in version 5.8.0 (link, link)
  • Update the dependency version of rc-field-form to 1.35.0 in package.json to support the strict option for getFieldsValue (link)

@stackblitz
Copy link

stackblitz bot commented Jul 26, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 26, 2023

@zombieJ zombieJ changed the title feat: strict feat: Form getFieldsValue support strict Jul 26, 2023
@socket-security
Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: rc-field-form@1.34.2

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 382.99 KB (+56 B 🔺)
./dist/antd-with-locales.min.js 442.54 KB (+52 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Jul 26, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 4 changes Jul 26, 2023, 1:50 PM

@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (ac3d917) 100.00% compared to head (4747ca8) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43828   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11118     11118           
  Branches      3009      3009           
=========================================
  Hits         11118     11118           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zombieJ zombieJ merged commit b3ccc46 into feature Jul 27, 2023
97 checks passed
@zombieJ zombieJ deleted the form-strict branch July 27, 2023 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants