Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: TreeSelect support customize clearIcon #43842

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Jul 27, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English TreeSelect support customize clear button
🇨🇳 Chinese 树选择组件支持自定义清除按钮

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at eb5afcc

Enhanced the allowClear property of the TreeSelect component to support custom clear icons. Updated the English and Chinese documentation files index.en-US.md and index.zh-CN.md accordingly.

🔍 Walkthrough

🤖 Generated by Copilot at eb5afcc

  • Enhance allowClear property of TreeSelect component to accept object type with clearIcon property for customizing clear icon (link, link)

@stackblitz
Copy link

stackblitz bot commented Jul 27, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 27, 2023

@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
./dist/antd.min.js 383.45 KB
./dist/antd-with-locales.min.js 442.96 KB

@codecov
Copy link

codecov bot commented Jul 27, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4858e60) 100.00% compared to head (eb5afcc) 100.00%.
Report is 3 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #43842   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11118     11143   +25     
  Branches      3009      3017    +8     
=========================================
+ Hits         11118     11143   +25     
Files Changed Coverage Δ
components/config-provider/context.ts 100.00% <ø> (ø)
components/config-provider/hooks/useTheme.ts 100.00% <100.00%> (ø)
components/config-provider/index.tsx 100.00% <100.00%> (ø)
components/theme/context.ts 100.00% <100.00%> (ø)
components/theme/useToken.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kiner-tang kiner-tang merged commit d64f8f6 into feature Jul 27, 2023
101 checks passed
@kiner-tang kiner-tang deleted the feat-treeSelect-allowClear branch July 27, 2023 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants