New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: custom feedback icons #43894
feat: custom feedback icons #43894
Conversation
(cherry picked from commit 22e43ad)
Run & review this pull request in StackBlitz Codeflow. |
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
ci failed, please check it. |
I fixed a failed test but it's not a test that I wrote. Btw, should I commit the jest snaps? I didn't commit them because there are 45 snaps changed that it's kind of strange to me. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #43894 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 678 678
Lines 11429 11434 +5
Branches 3080 3085 +5
=========================================
+ Hits 11429 11434 +5
☔ View full report in Codecov by Sentry. |
I changed and commited the new snaps. It passed all checks but "argos" is waiting for your decision. |
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: Gunay <gladio@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: Gunay <gladio@gmail.com>
Co-authored-by: afc163 <afc163@gmail.com> Signed-off-by: Gunay <gladio@gmail.com>
Conflicting |
Signed-off-by: Gunay <gladio@gmail.com>
Resolved. |
Signed-off-by: Gunay <gladio@gmail.com>
Signed-off-by: afc163 <afc163@gmail.com>
Signed-off-by: afc163 <afc163@gmail.com>
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
close #20245
💡 Background and solution
📝 Changelog
customFeedbackIcons
prop added toForm.Item
component and It is used withhasFeedback
as default feedback icons. This prop replaces the feedback icons with the given ones with ones.customFeedbackIcons
属性添加到Form.Item
组件,并与hasFeedback
一起用作默认反馈图标。 此道具将反馈图标替换为给定的图标。☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 13b57be
This pull request adds a new feature to the
Form.Item
component that enables users to customize the feedback icons for validation states. It modifies the component code, the test file, and the documentation files to support this feature. It also adds a new demo file and a markdown file to showcase the feature with an example.🔍 Walkthrough
🤖 Generated by Copilot at 13b57be
customFeedbackIcons
prop toForm.Item
component to allow customizing the feedback icons for different validation statuses (link, link, link, link, link)AlertFilled
icon from@ant-design/icons
package for use in test case and demo (link, link)customFeedbackIcons
feature incomponents/form/__tests__/index.test.tsx
file, usingAlertFilled
icon wrapped inTooltip
component as custom error icon (link)customFeedbackIcons
feature incomponents/form/demo/custom-feedback-icons.tsx
file, usingAlertFilled
icon wrapped inTooltip
component as custom error icon andantd-style
package to enable pointer events on feedback icon (link)customFeedbackIcons
demo incomponents/form/demo/custom-feedback-items.md
file, with brief description in Chinese and English and code block referencing demo file (link)customFeedbackIcons
demo toExamples
section of English documentation forForm
component incomponents/form/index.en-US.md
file, using<code>
tag to embed demo file and enable debugging mode (link)customFeedbackIcons
prop toForm.Item
section of English documentation forForm.Item
component incomponents/form/index.en-US.md
file, describing prop, type, default value, and version availability (link)customFeedbackIcons
demo to代码演示
section of Chinese documentation forForm
component incomponents/form/index.zh-CN.md
file, using<code>
tag to embed demo file and enable debugging mode (link)customFeedbackIcons
prop toForm.Item
section of Chinese documentation forForm.Item
component incomponents/form/index.zh-CN.md
file, describing prop, type, default value, and version availability (link)