Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled pagination should not have hover and focus style #43970

Merged
merged 3 commits into from Aug 2, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented Aug 2, 2023

  • fix: disabled pagination should not have hover and focus style
  • fix: update snapshot

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

close #43829

💡 Background and solution

这个 PR 仅仅是去掉了禁用时的 focus 样式,元素本身还是可以聚焦的。这个问题在 rc-pagination 修复

📝 Changelog

Language Changelog
🇺🇸 English Fix Pagination that should not have hover and focus style when disabled.
🇨🇳 Chinese 修复 Paginaition 组件禁用状态仍然有悬浮和聚焦样式的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 80d219a

This pull request improves the style and usability of the pagination component, especially the small size variant. It refactors the style rules in components/pagination/style/index.ts to remove duplication and simplify the code. It also adds two examples of small pagination components to components/pagination/demo/wireframe.tsx to demonstrate the new style and effects.

🔍 Walkthrough

🤖 Generated by Copilot at 80d219a

  • Simplify and unify the style rules for the mini pagination component (link, link, link, link, link)
  • Extract and reuse the focus style rules for the pagination component using a new function (link, link, link, link, link)
  • Add two examples of the mini pagination component to the wireframe demo file (link)

@stackblitz
Copy link

stackblitz bot commented Aug 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 389.79 KB (-32 B 🔽)
./dist/antd-with-locales.min.js 448.69 KB (-32 B 🔽)

@argos-ci
Copy link

argos-ci bot commented Aug 2, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Aug 2, 2023, 1:43 PM

@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6ca1b6d) 100.00% compared to head (0651fc0) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #43970   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11166     11169    +3     
  Branches      3024      3024           
=========================================
+ Hits         11166     11169    +3     
Files Changed Coverage Δ
components/pagination/style/index.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MadCcc MadCcc merged commit 8f2de9a into master Aug 2, 2023
88 checks passed
@MadCcc MadCcc deleted the fix/pagoination branch August 2, 2023 14:04
@zombieJ zombieJ mentioned this pull request Aug 4, 2023
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Items of disabled Pagination are focus-visible and disabled wireframe Pagination on hover changes styles
2 participants