fix: RangePicker allowClear does not disable the clear button #44015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
|
bartpio
force-pushed
the
date-picker-allow-clear-false
branch
2 times, most recently
from
fd7e757
to
70d79af
Compare
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #44015 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 658 658
Lines 11178 11186 +8
Branches 3027 3029 +2
=========================================
+ Hits 11178 11186 +8
☔ View full report in Codecov by Sentry. |
bartpio
force-pushed
the
date-picker-allow-clear-false
branch
2 times, most recently
from
d50dc55
to
c7f5643
Compare
kiner-tang
reviewed
Aug 4, 2023
bartpio
force-pushed
the
date-picker-allow-clear-false
branch
2 times, most recently
from
bae3fa7
to
025ada1
Compare
This comment was marked as resolved.
This comment was marked as resolved.
kiner-tang
reviewed
Aug 4, 2023
reflects actual desired outcome when allowClear is false
bartpio
force-pushed
the
date-picker-allow-clear-false
branch
from
025ada1
to
8c66709
Compare
bartpio
force-pushed
the
date-picker-allow-clear-false
branch
from
8c66709
to
853089c
Compare
This comment was marked as resolved.
This comment was marked as resolved.
It doesn't matter! That maybe a bug of argos! |
kiner-tang
approved these changes
Aug 4, 2023
20 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
Fix #44012
💡 Background and solution
A regression was introduced in 24697bb that results in
generatePickerandgenerateRangePickerbuilding the finalallowClearprop solely from theclearIconprop, without respectingallowClear===false. This makes it impossible for the library user to make a date picker non-clearable.The proposed solution uses
allowClear, as provided to the date picker, when it isfalseor an object bearingclearIcon. Otherwise, the finalallowClearprop is built from theclearIconprop.The proposed solution skips building an icon-bearingallowClearprop, when theallowClearprop on the date picker is set tofalse, and theclearIconprop on the date picker is undefined.📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at 025ada1
The pull request adds a new feature to the
DatePickerandRangePickercomponents that allows users to customize the clear icon. The pull request also improves the testing of these components by using new modules, components, and utilities. The pull request modifies the filescomponents/date-picker/generatePicker/generateRangePicker.tsx,components/date-picker/generatePicker/generateSinglePicker.tsx,components/date-picker/util.ts,components/date-picker/__tests__/DatePicker.test.tsx,components/date-picker/__tests__/RangePicker.test.tsx, andcomponents/date-picker/__tests__/utils.ts.🔍 Walkthrough
🤖 Generated by Copilot at 025ada1
allowClearprop to theDatePickerandRangePickercomponents, which can be a boolean or an object that specifies theclearIcon(link, link, link, link, link)mergeAllowClearfunction from theutil.tsmodule in thegenerateSinglePicker.tsxandgenerateRangePicker.tsxmodules, which handles the logic of theallowClearprop (link, link, link)allowClearprop in theDatePicker.test.tsxandRangePicker.test.tsxmodules, which verify the existence and appearance of the clear icon (link, link)userEvent,screen,waitFor, andCloseCircleFilledin theDatePicker.test.tsxandRangePicker.test.tsxmodules, and use them in the new test cases (link, link, link)utils.tsmodule, and use them in the new test cases (link)