Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(DatePicker): RangePicker support rootClassName #44057

Merged
merged 4 commits into from Aug 7, 2023

Conversation

kiner-tang
Copy link
Member

@kiner-tang kiner-tang commented Aug 6, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English RangePicker support rootClassName
🇨🇳 Chinese 日期范围选择器支持 rootClassName

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 0c0f90b

This pull request adds a new prop rootClassName to the RangePicker component, which allows users to customize the root class name of the date picker panel. It also updates the tests and the documentation for the new prop in both English and Chinese.

🔍 Walkthrough

🤖 Generated by Copilot at 0c0f90b

  • Add rootClassName prop to RangePicker component to allow customizing the root element's class name (link, link, link, link, link)
  • Pass rootClassName prop from RangePicker to Picker and PickerPanel components in generateRangePicker.tsx (link, link)
  • Test rootClassName prop in RangePicker.test.tsx by checking the snapshot and the prop's value on the root element (link)

@stackblitz
Copy link

stackblitz bot commented Aug 6, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 6, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 386.66 KB (-2 B 🔽)
./dist/antd-with-locales.min.js 445.8 KB (+5 B 🔺)

@codecov
Copy link

codecov bot commented Aug 6, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (6ca1b6d) 100.00% compared to head (aa76ed8) 100.00%.
Report is 29 commits behind head on feature.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #44057   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          658       658           
  Lines        11166     11223   +57     
  Branches      3024      3047   +23     
=========================================
+ Hits         11166     11223   +57     
Files Changed Coverage Δ
components/_util/wave/index.ts 100.00% <ø> (ø)
components/_util/wave/style.ts 100.00% <ø> (ø)
components/anchor/style/index.ts 100.00% <ø> (ø)
components/checkbox/style/index.ts 100.00% <ø> (ø)
components/config-provider/context.ts 100.00% <ø> (ø)
...ate-picker/generatePicker/generateSinglePicker.tsx 100.00% <ø> (ø)
components/drawer/style/index.ts 100.00% <ø> (ø)
components/input-number/style/index.ts 100.00% <ø> (ø)
components/input/style/index.ts 100.00% <ø> (ø)
components/table/style/rtl.ts 100.00% <ø> (ø)
... and 12 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants